Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALS-6173] small hpds optimization #104

Closed
wants to merge 1 commit into from
Closed

[ALS-6173] small hpds optimization #104

wants to merge 1 commit into from

Conversation

Luke-Sikina
Copy link
Member

  • optimize getValuesForKeys to work with sorted id lists

[ALS-6173] small hpds optimization
fce92ca 
- optimize getValuesForKeys to work with sorted id lists
@Luke-Sikina Luke-Sikina added the enhancement New feature or request label Mar 28, 2024
Luke-Sikina
Luke-Sikina commented Mar 28, 2024
View reviewed changes
data/src/test/java/edu/harvard/hms/dbmi/avillach/hpds/data/phenotype/PhenoCubeTest.java
@@ -0,0 +1,93 @@
package edu.harvard.hms.dbmi.avillach.hpds.data.phenotype;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great unit tests, Luke! I feel much safer about approving this pull request knowing that you've put this level of effort into insuring the correctness of your changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Luke-Sikina Luke-Sikina deleted the hpds-tuning branch April 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Luke-Sikina