Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALS-6265] Add any record of multi support to time series processor #108

Merged
merged 1 commit into from
Jun 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.*;
import java.util.stream.Collectors;

import edu.harvard.hms.dbmi.avillach.hpds.processing.AbstractProcessor;
import edu.harvard.hms.dbmi.avillach.hpds.processing.AsyncResult;
Expand Down Expand Up @@ -94,6 +95,7 @@ private void exportTimeData(Query query, AsyncResult result, TreeSet<Integer> id
//get a list of all fields mentioned in the query; export all data associated with any included field
List<String> pathList = new LinkedList<String>();
pathList.addAll(query.getAnyRecordOf());
pathList.addAll(query.getAnyRecordOfMulti().stream().flatMap(Collection::stream).collect(Collectors.toList()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to exponentially increase the data being returned in some cases. Is performance a worry here? And do people really expect to get all of this data back?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, as it stands, when you request data from an any record of multi query, you get nothing back. We can deal with slow exports in GIC; as long as HPDS doesn't run oom, it doesn't really matter.

pathList.addAll(query.getFields());
pathList.addAll(query.getRequiredFields());
pathList.addAll(query.getCategoryFilters().keySet());
Expand Down
Loading