ALS-6511: Add PFB result type #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramari16
commented
Aug 13, 2024
| @@ -17,7 +23,19 @@ | |||
| public class AsyncResult implements Runnable, Comparable<AsyncResult>{ | |||
There was a problem hiding this comment.
This class was a huge pain. I tried to improve it but I'm not super happy with how this turned out. But at least this supports multi value exporting, to some degree
ramari16
commented
Aug 13, 2024
| import java.util.stream.Stream; | ||
|
|
||
| @Component | ||
| public class PfbProcessor implements HpdsProcessor { |
There was a problem hiding this comment.
This is somewhat similar to the QueryProcessor which generates the CSVs, but since PFB needs to write row by row, we batch the rows and then transform the column-based data to row based data before writing
ramari16
commented
Aug 13, 2024
| import org.apache.commons.csv.CSVPrinter; | ||
| import org.apache.commons.csv.CSVRecord; | ||
|
|
||
| import de.siegmar.fastcsv.writer.CsvWriter; | ||
| import edu.harvard.hms.dbmi.avillach.hpds.data.phenotype.ColumnMeta; | ||
|
|
||
| public class ResultStoreStream extends InputStream { |
There was a problem hiding this comment.
A lot of these changes are removing an obsolete concept that was no longer in use. The important part is making the writer more generic
ramari16
commented
Aug 13, 2024
| import java.util.*; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class PfbWriter implements ResultWriter { |
There was a problem hiding this comment.
This is the class responsible for creating the PFB file, using Java's avro library
Luke-Sikina
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.