Document.reorder: invalidate OcrdMets cache before save #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kba I'm really sorry that took so long, I had dayjob stuff to do and a broken ocrd/python/os-environment. |
Not a problem, thanks for continuing to work on browse-ocrd, it has become my preferred tool to inspect/present OCR-D results and we're very happy to have it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in OCR-D/core#957, the
reordermethod ofDocumentchanges the XML structure withoutOcrdMetsbeing aware of it. We introduced optional caching of METS data in v2.42.0 and when enabled this led to inconsistency becauseOcrdMets.physical_pagesdid not reflect the changes because caching hid them.@MehmedGIT therefore introduced a method
OcrdMets.refresh_cachesto refresh the cache from the XML.This PR adds the refresh_caches call just before
self.save_mets()which fixes the problem.Also additonally run all tests with caching enabled to make sure we notice caching issues in the future.