Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message for /verify/resend route #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Topman-14
Copy link
Collaborator

@Topman-14 Topman-14 commented Oct 22, 2023

This is a quick fix for the 200 status code being returned when a resend verification fails due to an internal server error.

Description

affected files - controllers/UserController/messaging.ts, services/UserService/index.ts
route - /verify/resend

Motivation and Context

This PR allows for proper error handling and toast notification on the front-end.
​​

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

Screenshot from 2023-10-22 21-30-15

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Topman-14
Copy link
Collaborator Author

@pesova please help me check and merge 🙏🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant