Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View badges fixes bugs #1472

Open
wants to merge 63 commits into
base: dev
Choose a base branch
from
Open

View badges fixes bugs #1472

wants to merge 63 commits into from

Conversation

ggakila
Copy link
Collaborator

@ggakila ggakila commented Oct 22, 2023

you can check this one that was used for the previous cohort

Fixes Issue/Linear Ticket

This could be an existing issue or a linear ticket

  • Github Issue Example: My PR Closes #{ISSUE}
  • Linear Ticket Example: Fixes ID-#{ISSUE}

Changes proposed

Stg 9 bugs:
Attached video link
Prev Fixes:
1.Badges Dahsboard Banner content aligned with nav and rooter
2. Badge component interactivity added
3. No earned badges error state dimensions change to get rid of spacing underneath the footer
4.History back button added to badges dashboard to allow navigation to any previous page
5. Added SEO -Meta data for improved SEO etc
6. Badge component allignment with nav and footer
7. loading state ui change to remove extra space below the footer
8. No earned bdges ui change for better ui/ux-centered and responsive
9. fix badge earne at date to show update at date for when user retakes assessment
10. fix dashboard banner text grammar- fix image alt text for improved accessibility

Talk about the things you did eg. files changes, dependencies installed e.t.c

Check List (Check all the applicable boxes)

🚨Please review the [style guide for contributing](add link here) and [guidelines for contributing](add link here) to this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the main branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/ Videos

stg 9:
https://drive.google.com/file/d/192_eMUlM4DaKOTO8edht-XgMjkSfCYzJ/view?usp=share_link

prev

badgesdashboard after
badgesdashboard before
errorpage before
errorpage after

TRIPLE-ADE and others added 30 commits October 14, 2023 09:26
@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zuriportfolio-frontend ❌ Failed (Inspect) Oct 22, 2023 7:41pm

@vercel
Copy link

vercel bot commented Oct 22, 2023

Deployment failed with the following error:

Resource is limited - try again in 25 seconds (more than 100, code: "api-deployments-free-per-day").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants