Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethfs v2 #20

Merged
merged 82 commits into from
Dec 28, 2023
Merged

ethfs v2 #20

merged 82 commits into from
Dec 28, 2023

Conversation

holic
Copy link
Owner

@holic holic commented Dec 10, 2023

TODO

  • restore old contracts for backwards compat
    • gonna let git handle this, folks can copy old interfaces if they need em
  • see about colocating foundry tests with their source files
  • figure out why "execution reverted" or viem can't parse errors from createFile call (maybe ABI doesn't include em)
  • figure out how to verify contracts after deploy
  • allow creating file directly from bytes instead of pointers?
  • support more chains
  • switch foundry deps to npm
    • tried this but failed for remappings of common deps of deps (e.g. forge-std) and didn't wanna sink too much time into it
  • try out solady's fastlz
    • will it unzip gzip files?
  • update estimated gas for uploads
    • writing to ContentStore has more gas now, but ~same if we write directly to the deployer instead of ContentStore
    • if significantly more (due to second layer of contract calls), consider making ContentStore a library
  • try date-fns instead of luxon
    • date-fns has no way to specify "relative time in days", so sticking with luxon for now
  • move metadata to a struct?
  • rename BytecodeSlice's size and offset to start and end?

@holic holic temporarily deployed to holic/deterministic - ethfs-shovel September 5, 2024 22:17 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel September 5, 2024 22:22 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel September 6, 2024 07:36 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel September 6, 2024 07:42 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web September 6, 2024 07:42 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 09:41 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 09:41 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 09:51 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 09:51 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 09:59 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 09:59 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 10:02 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 10:02 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 10:04 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 10:04 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 10:05 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 10:05 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 20:33 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 20:33 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 20:35 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 20:35 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 21:30 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-shovel January 22, 2025 21:30 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 22:05 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 22, 2025 22:10 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 23, 2025 23:25 — with Render Inactive
@holic holic temporarily deployed to holic/deterministic - ethfs-web January 23, 2025 23:25 — with Render Inactive
@holic holic deleted the holic/deterministic branch January 30, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant