Add utilities for auto-generating param Python types #636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at implementing a solution for #376
Major, major HACKALERT for now as there a large number of unsafe/incomplete details here:
pytype
properties not completeParameterized
toast.ClassDef
node not entirely safeParameter
toast.Assign
/ast.AnnAssign
node not entirely safepytype
property into valid type definition string not safeint | None
orUnion[int, None]
rather thanOptional[int]
pname =
pname: int =
will not worktyping
module has been imported. Should eventually check if typing is imported and allow configurability betweenimport typing
andfrom typing import ...
ClassSelector
/List
class_
definition from the ast node), but e.g.param.Array
->np.ndarray
would require checking if numpy has been imported and if not adding the import.Further work for viability:
Example
Here is an example of the types generated for
panel.viewable.Layoutable
(doc
definitions omitted for readability):