Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce optimizations in GeneralizedMorphismsForCAP #1670

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

zickgraf
Copy link
Member

to avoid timeouts in tests in CategoricalTowers

The optimizations probably do not fulfill the specification "equal input gives equal output",
see #1669

to avoid timeouts in tests in CategoricalTowers

The optimizations probably do not fulfill the specification
"equal input gives equal output",
see homalg-project#1669
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.33%. Comparing base (fcaf120) to head (6200387).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...AP/gap/GeneralizedMorphismCategoryByThreeArrows.gi 84.84% 5 Missing ⚠️
...msForCAP/gap/GeneralizedMorphismCategoryBySpans.gi 75.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1670   +/-   ##
=======================================
  Coverage   81.32%   81.33%           
=======================================
  Files         538      538           
  Lines       67225    67282   +57     
=======================================
+ Hits        54673    54721   +48     
- Misses      12552    12561    +9     
Flag Coverage Δ
ActionsForCAP 64.09% <ø> (ø)
AttributeCategoryForCAP 90.45% <ø> (ø)
CAP 84.11% <ø> (ø)
CartesianCategories 90.95% <ø> (ø)
CompilerForCAP 95.86% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.60% <ø> (ø)
FreydCategoriesForCAP 81.56% <ø> (ø)
GeneralizedMorphismsForCAP 61.81% <86.20%> (+0.53%) ⬆️
GradedModulePresentationsForCAP 44.62% <ø> (ø)
GroupRepresentationsForCAP 71.92% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.09% <ø> (ø)
LinearAlgebraForCAP 66.54% <ø> (ø)
ModulePresentationsForCAP 69.88% <ø> (ø)
ModulesOverLocalRingsForCAP 90.70% <ø> (ø)
MonoidalCategories 88.48% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zickgraf zickgraf merged commit be1c838 into homalg-project:master Sep 11, 2024
5 checks passed
@zickgraf zickgraf deleted the additional_filters branch September 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant