fix: various issues with docker image workflow #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional statements were all in the form of `input || true`, presumably in an effort to treat this as `true` if the input was not set as it would be when the trigger is a push rather than a manual dispatch (`null || true` => `true`). However `false || true` also results in `true`, so this would just always result in `true`. Changing this to `!= false` does result in the desired behaviour: - Enabled: `true != false` => `true` - Disabled: `false != false` => `false` - Unset: `null != false` => `true`
|
Here's the code health analysis summary for commits Analysis Summary
|
MaienM
changed the title
manuel-rw
previously approved these changes
Sep 25, 2024
MaienM
force-pushed
the
fix-workflow
branch
from
d3cbc97 to
623c73a
Compare
manuel-rw
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional statements were all in the form of
input || true, presumably in an effort to treat this astrueif the input was not set as it would be when the trigger is a push rather than a manual dispatch (null || true=>true). Howeverfalse || truealso results intrue, so this would just always result intrue.Changing this to
!= falsedoes result in the desired behaviour:true != false=>truefalse != false=>falsenull != false=>trueIt was always looking at the
devbranch for the commit messages in the versioning step, which meant that running it against a different branch would not have the desired result.