Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RTL option to RSS widget #1247

Merged
merged 5 commits into from
Oct 21, 2024
Merged

feat: RTL option to RSS widget #1247

merged 5 commits into from
Oct 21, 2024

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Oct 5, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy requested a review from a team as a code owner October 5, 2024 13:06
Copy link

deepsource-io bot commented Oct 5, 2024

Here's the code health analysis summary for commits 7e219bc..85cf734. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@hillaliy hillaliy changed the title RTL option to RSS widget feat: RTL option to RSS widget Oct 5, 2024
@hillaliy hillaliy self-assigned this Oct 5, 2024
Copy link

github-actions bot commented Oct 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.84% 14545 / 37443
🔵 Statements 38.84% 14545 / 37443
🔵 Functions 35.97% 377 / 1048
🔵 Branches 71.02% 1294 / 1822
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/old-import/src/widgets/options.ts 83.19% 100% 0% 83.19% 124-130, 132-144
packages/old-import/src/widgets/definitions/rss.ts 0% 0% 0% 0%
packages/translation/src/lang/en.ts 100% 100% 100% 100%
packages/widgets/src/rssFeed/component.tsx 0% 0% 0% 0% 1-3, 5, 8, 10-12, 14-25, 27-37, 39, 41-53, 55-56, 59-71, 74-79, 81, 83-89
packages/widgets/src/rssFeed/index.ts 100% 100% 100% 100%
Generated in workflow #3329 for commit 85cf734 by the Vitest Coverage Report Action

@hillaliy hillaliy marked this pull request as draft October 5, 2024 13:44
@Meierschlumpf
Copy link
Member

I think this should work already when merging #1246

@hillaliy hillaliy closed this Oct 5, 2024
@hillaliy hillaliy deleted the RTL-option-to-RSS-widget branch October 5, 2024 17:03
@hillaliy hillaliy restored the RTL-option-to-RSS-widget branch October 19, 2024 04:44
@hillaliy hillaliy reopened this Oct 19, 2024
@hillaliy
Copy link
Contributor Author

Before:
Screenshot 2024-10-19 at 7 48 12

After:
Screenshot 2024-10-19 at 7 49 31

@hillaliy hillaliy marked this pull request as ready for review October 19, 2024 04:53
@manuel-rw
Copy link
Member

@hillaliy hillaliy requested a review from manuel-rw October 20, 2024 06:02
@hillaliy hillaliy merged commit 9a7e845 into dev Oct 21, 2024
10 checks passed
@hillaliy hillaliy deleted the RTL-option-to-RSS-widget branch October 21, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants