Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add manifest #1309

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat: add manifest #1309

merged 1 commit into from
Oct 16, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Oct 16, 2024
@Meierschlumpf Meierschlumpf self-assigned this Oct 16, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner October 16, 2024 14:41
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Oct 16, 2024

Here's the code health analysis summary for commits c4ec4f3..13bad8a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.93% 14521 / 37296
🔵 Statements 38.93% 14521 / 37296
🔵 Functions 36% 377 / 1047
🔵 Branches 70.8% 1288 / 1819
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/manifest.ts 0% 100% 100% 0% 3-39
Generated in workflow #3269 for commit 13bad8a by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit 727f104 into dev Oct 16, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the add-manifest branch October 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw approved these changes

Assignees

@Meierschlumpf Meierschlumpf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meierschlumpf @manuel-rw