Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move from next-international to next-intl #1368

Merged
merged 11 commits into from
Oct 26, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Oct 24, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

As https://github.com/QuiiBz/next-international seems not to be maintained since february. I've decided to switch to a better path moving forward. The translations were not necessary to change, but the structure for some functionallities are not the same. Please checkout the documentation of next-intl as it provides good examples and design principles.

  • I'll add some comments and restructure the stuff before it's ready for review

@Meierschlumpf Meierschlumpf self-assigned this Oct 24, 2024
Copy link

deepsource-io bot commented Oct 24, 2024

Here's the code health analysis summary for commits 041006c..f011c4e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Oct 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.75% 14667 / 37846
🔵 Statements 38.75% 14667 / 37846
🔵 Functions 35.83% 382 / 1066
🔵 Branches 70.84% 1300 / 1835
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/next.config.mjs 0% 0% 0% 0% 1-41
apps/nextjs/src/app/[locale]/layout.tsx 0% 0% 0% 0% 1-2, 4-7, 9-11, 13-18, 20-26, 28-31, 33-54, 56-61, 63-66, 68-72, 74-83, 85, 87-94, 96-106, 108, 110-112
apps/nextjs/src/app/[locale]/manage/users/create/_components/create-user-stepper.tsx 0% 0% 0% 0% 1, 3-5, 7-13, 15, 17-19, 21-29, 31-40, 42-53, 55-74, 76, 78-80, 82-92, 94-99, 101-109, 111-119, 121-152, 154-183, 185
apps/nextjs/src/app/[locale]/manage/users/groups/[id]/_reserved-group-alert.tsx 0% 0% 0% 0% 1-3, 5-6, 8-9, 11-19, 21-22, 24-25, 27
apps/nextjs/src/components/language/language-combobox.tsx 0% 0% 0% 0% 1, 3-5, 8-9, 11, 13-18, 20-29, 31-33, 35-46, 48-60, 62, 64-68, 72-85, 87
packages/common/src/types.ts 0% 0% 0% 0%
packages/modals-collection/src/invites/invite-copy-modal.tsx 0% 0% 0% 0% 1-3, 6-7, 9-11, 13-25, 27-40, 42-43, 45-46, 48-52, 54, 56-57, 59-60
packages/spotlight/src/modes/command/children/language.tsx 0% 0% 0% 0% 1-2, 4-5, 7, 9-46, 48-50, 52-57, 59-62, 64-65
packages/translation/src/config.ts 100% 100% 100% 100%
packages/translation/src/index.ts 46.15% 100% 0% 46.15% 11-15, 18-19
packages/translation/src/middleware.ts 0% 0% 0% 0% 1, 3, 5, 7, 9-10
packages/translation/src/request.ts 0% 0% 0% 0% 1-2, 4, 6-7, 10-11, 13-16, 18-19, 22-28, 30-34
packages/translation/src/routing.ts 0% 0% 0% 0% 1, 3, 5-11
packages/translation/src/server.ts 0% 0% 0% 0% 1, 3-6
packages/translation/src/type.ts 0% 0% 0% 0%
packages/translation/src/client/index.ts 100% 100% 0% 100%
packages/translation/src/client/use-change-locale.ts 20% 100% 0% 20% 8-11, 13-17, 19-25
packages/translation/src/client/use-current-locale.ts 100% 100% 0% 100%
packages/translation/src/lang/en.ts 100% 100% 100% 100%
packages/ui/src/components/beta-badge.tsx 40% 100% 0% 40% 13-17, 19
packages/ui/src/hooks/use-translated-mantine-react-table.ts 0% 0% 0% 0% 1-2, 4, 6-14
packages/validation/src/user.ts 100% 100% 100% 100%
packages/validation/src/form/i18n.ts 8.54% 50% 16.66% 8.54% 7-18, 21-25, 27-42, 44-50, 52-55, 58-62, 64-68, 70-77, 80-84, 86-93, 96-101, 103-124, 126-129
packages/widgets/src/widget-integration-select.tsx 7.84% 100% 0% 7.84% 37-43, 45-48, 50-55, 57-58, 60-64, 66-67, 69-84, 86, 88-99, 101-102, 104-106, 108-109, 111-116, 118, 120-126, 128-131, 133-135, 137-139, 141, 156-162
packages/widgets/src/_inputs/widget-app-input.tsx 28.57% 100% 0% 28.57% 18-21, 23-26, 28-41, 43-50, 52-53, 55-56, 58, 68-74, 84-86, 88-90, 92-93
packages/widgets/src/test/translation.spec.ts 88.88% 80% 100% 88.88% 16-17, 34-35
Generated in workflow #3401 for commit f011c4e by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf marked this pull request as ready for review October 24, 2024 21:57
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner October 24, 2024 21:57
@Meierschlumpf Meierschlumpf merged commit 4502569 into dev Oct 26, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the migrate-translation-library branch October 26, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants