-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for all languages from old homarr #1394
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! It's impressive
- Did you make sure that this format is compatible with crowdin ? It might require to have a
.json
file and import it in the.ts
as a valid directly (no need for validation) - Do you plan to add back the live translation feature (Crowdin) ? I made it so that the script is added to the page depending on the user preference
- I saw you're switching to next-intl (the translation thing from crowdin), they support a localstorage adapter if I recall correctly so you could make it so that translations are only passed once then saved in localstorage, also could utilize translations come from Crowdin's CDN to synchronize them with the app (in a chron job?) with Crowdin's OTA translations feature. (I believe they gave us a Pro plan for open-source so we have pretty much all features for free)
- Last comment the i18n ally vscode extension works really well with this plugin so maybe add a config into the
.vscode
folder that takes care of this, then you can have auto-add keys/inline keys replacement (it will show the translations) and also a warning when a text is not translated
|
Test issue: vitest-dev/vitest#5101 |
So... what do we do about this then?
I agree, let's plan this for >1.0. |
I already changed it to JSON |
Stupid question. Would we have an advantage storing as JSON but converting to TS on the fly / on commit? |
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm buid
, autofix withpnpm format:fix
)dev
branchx
,y
,i
or any abbrevation)All translations from non english were migrated from old homarr with a script. It may contain incorrect translations. Overall 300 / 1050 translations were copied.
Created issue #1402 for crowdin integration and made a prototype with a project on my own to verify it would work with the current structure