Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix i18n-ally extension config #1462

Merged
merged 2 commits into from
Nov 17, 2024
Merged

fix: fix i18n-ally extension config #1462

merged 2 commits into from
Nov 17, 2024

Conversation

ajnart
Copy link
Contributor

@ajnart ajnart commented Nov 11, 2024 •
edited
Loading

Before / After

Before 😭 After 😎
image image

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Nov 11, 2024 •
edited
Loading

Here's the code health analysis summary for commits 2a45c5b..a202ccc. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.07% 6381 / 28911
🔵 Statements 22.07% 6381 / 28911
🔵 Functions 24.02% 246 / 1024
🔵 Branches 60.73% 778 / 1281
File CoverageNo changed files found.
Generated in workflow #3660 for commit a202ccc by the Vitest Coverage Report Action

@ajnart ajnart marked this pull request as ready for review November 11, 2024 08:57
@ajnart ajnart requested a review from a team as a code owner November 11, 2024 08:57
@Meierschlumpf Meierschlumpf added the bug Something isn't working label Nov 11, 2024
Meierschlumpf
Meierschlumpf requested changes Nov 11, 2024
View reviewed changes
.vscode/i18n-ally-custom-framework.yml Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@Meierschlumpf Meierschlumpf merged commit 4ba9e94 into dev Nov 17, 2024
11 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-i18n-ally branch November 17, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meierschlumpf Meierschlumpf Meierschlumpf approved these changes

Assignees

@ajnart ajnart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnart @Meierschlumpf