Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pretty-print-error to print errors in console #1596

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Dec 3, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Sorry, had to reopen the pull request from #1586 as it was not updating the pr correctly
Can be merged once #1595 is merged to dev

image

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Dec 3, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner December 3, 2024 16:53
Copy link

deepsource-io bot commented Dec 3, 2024

Here's the code health analysis summary for commits bf45860..067c274. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Dec 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.19% 7198 / 29750
🔵 Statements 24.19% 7198 / 29750
🔵 Functions 25.95% 272 / 1048
🔵 Branches 63.94% 846 / 1323
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/request-handler/src/lib/cached-request-integration-job-handler.ts 14.92% 100% 100% 14.92% 36-103
Generated in workflow #3994 for commit 067c274 by the Vitest Coverage Report Action

manuel-rw
manuel-rw previously approved these changes Dec 4, 2024
@manuel-rw manuel-rw merged commit 71f4f8c into dev Dec 5, 2024
13 checks passed
@Meierschlumpf Meierschlumpf deleted the fix/print-console-errors-in-log branch December 16, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants