Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add analytics #528

Merged
merged 7 commits into from
May 26, 2024
Merged

feat: add analytics #528

merged 7 commits into from
May 26, 2024

Conversation

manuel-rw
Copy link
Member

@manuel-rw manuel-rw commented May 20, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@manuel-rw manuel-rw changed the title Feat/add analytics feat: add analytics May 20, 2024
@manuel-rw manuel-rw force-pushed the feat/add-analytics branch from 3c29300 to 3933788 Compare May 20, 2024 19:59
@manuel-rw manuel-rw marked this pull request as ready for review May 22, 2024 18:57
@manuel-rw manuel-rw requested a review from a team as a code owner May 22, 2024 18:57
@manuel-rw manuel-rw force-pushed the feat/add-analytics branch 2 times, most recently from 8a82f13 to 8f9136a Compare May 23, 2024 15:52
SeDemal
SeDemal previously approved these changes May 25, 2024
Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled by default right?
lgtm

@manuel-rw manuel-rw requested a review from SeDemal May 25, 2024 18:54
@manuel-rw manuel-rw self-assigned this May 25, 2024
SeDemal
SeDemal previously approved these changes May 25, 2024
Meierschlumpf
Meierschlumpf previously approved these changes May 25, 2024
Copy link
Member

@Meierschlumpf Meierschlumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay let's merge

@Meierschlumpf Meierschlumpf merged commit 7e64d39 into dev May 26, 2024
6 of 8 checks passed
@Meierschlumpf Meierschlumpf deleted the feat/add-analytics branch May 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants