Update sensor.py - add WH46's PM1 and PM4 measurement support #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of WH46 air quality sensor's PM1 + PM4 measurement to fix home-assistant/core#125003
Code changes are required on both home-assistant-libs/aioecowitt/aioecowitt/sensor.py and home-assistant/core/homeassistant/components/ecowitt/sensor.py, so this is only the first PR of two. Due to the library dependency, approval of this PR will be required before the other can be issued.
Both code changes are already tested successfully on my install.