Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitattributes file #5000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented Jan 21, 2025

Summary

Note: this does not run any normalization on the existing files, it
simply adds the gitattributes. I can add the existing file normalization
either in this PR or a future one.

This is based on this gitattributes file from the Gradle repo: https://github.com/gradle/gradle/blob/master/.gitattributes

Note: this does not run any normalization on the existing files, it
simply adds the gitattributes. I can add the existing file normalization
either in this PR or a future one.
@jpelgrom
Copy link
Member

This is based on this gitattributes file from the Gradle repo: https://github.com/gradle/gradle/blob/master/.gitattributes

Any particular reason for using this one? It seems reasonable to me but would've expected a more Android-specific one.

I can add the existing file normalization either in this PR or a future one.

I don't see why we'd do it in a different PR. If you rebase first, the wrapper changes should be included, and renormalizing then should only change lines for files, no content changes.

*.bat text eol=crlf

# Java/kotlin sources
*.java text diff=java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have Java files and won't add them, so this line isn't needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants