Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require a wifi password to connect Improv. #5019

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

abliss
Copy link
Contributor

@abliss abliss commented Jan 30, 2025

Summary

Attempt to fix #5018 by not requiring a WiFi password to connect an Improv device.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

I have not tested this at all; it's just a wild guess.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abliss

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 30, 2025 04:34
@abliss abliss marked this pull request as ready for review January 30, 2025 05:46
@jpelgrom
Copy link
Member

jpelgrom commented Jan 30, 2025

I have not tested this at all; it's just a wild guess.

You can easily test this by downloading the artifact for this PR (scroll to the bottom, you must be logged in to GitHub to download). The app installs alongside the production app. Please let us know if it works as this seems like a niche use case.

(I'm unable to test this - my consumer-grade router simply does not allow a wireless network without a password, as it should.)

@abliss
Copy link
Contributor Author

abliss commented Jan 30, 2025

Thanks! I tested the artifact and it works great.

(I'm curious why you think it "seems like a niche use case". I googled and clicked on the first link which claimed that "A 2022 report from PC Matic found 89% of people don’t have a password set up on their wifi". I certainly am not vouching for the report's methodology but what leads you to believe it is so wrong? Also, naively and without data, I would guess that the percentage should be even higher amongst Home Assistant users, just because they are more likely to be tech-savvy enough to understand that wifi passwords are pointless and counterproductive.)

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to match the core config flow.

@jpelgrom jpelgrom merged commit 514057a into home-assistant:master Jan 30, 2025
4 checks passed
@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add discovered Improv device: wifi dialog "Continue" button disabled.
2 participants