-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require a wifi password to connect Improv. #5019
Do not require a wifi password to connect Improv. #5019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
You can easily test this by downloading the artifact for this PR (scroll to the bottom, you must be logged in to GitHub to download). The app installs alongside the production app. Please let us know if it works as this seems like a niche use case. (I'm unable to test this - my consumer-grade router simply does not allow a wireless network without a password, as it should.) |
Thanks! I tested the artifact and it works great. (I'm curious why you think it "seems like a niche use case". I googled and clicked on the first link which claimed that "A 2022 report from PC Matic found 89% of people don’t have a password set up on their wifi". I certainly am not vouching for the report's methodology but what leads you to believe it is so wrong? Also, naively and without data, I would guess that the percentage should be even higher amongst Home Assistant users, just because they are more likely to be tech-savvy enough to understand that wifi passwords are pointless and counterproductive.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to match the core config flow.
Summary
Attempt to fix #5018 by not requiring a WiFi password to connect an Improv device.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
I have not tested this at all; it's just a wild guess.