Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Add dependency uploading #5048

Conversation

colin-foster-in-advantage
Copy link
Contributor

Summary

The gradle components don't automatically get detected upon build. Use the dependency-submission API to enable this dependency tracking.

Documentation explaining this:

https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/dependency-graph-supported-package-ecosystems#package-ecosystems-supported-via-dependency-submission-actions

That article links to this action:

https://github.com/marketplace/actions/build-with-gradle#the-dependency-submission-action

Screenshots

The GitHub front end will change 😄 It currently only displays GitHub and Ruby dependencies, not Gradle.

image

Link to pull request in Documentation repository

N/A

Any other notes

This is only for housekeeping / dependencies. I wasn't able to test the action easily due to app secrets, but it should work.

The gradle components don't automatically get detected upon build. Use
the dependency-submission API to enable this dependency tracking.
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @colin-foster-in-advantage

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 18, 2025 04:21
@colin-foster-in-advantage colin-foster-in-advantage marked this pull request as ready for review February 18, 2025 04:35
@jpelgrom
Copy link
Member

Thanks for the suggestion, it looks good to me. Could you explain "This is only for housekeeping" a bit more?

@colin-foster-in-advantage
Copy link
Contributor Author

Thanks for the suggestion, it looks good to me. Could you explain "This is only for housekeeping" a bit more?

Yep. It'll do two things (as far as I understand).

  1. It'll populate the dependencies correctly in the screenshot I included. That'll make "Export SBOM" correctly include Gradle dependencies in the SPDX export. It currently only references Ruby Gems and github actions.
  2. It'll (likely?) publish security advisories in the "Security" tab. This one might differ based on how the repository is configured.

@dshokouhi dshokouhi merged commit b384724 into home-assistant:master Feb 19, 2025
4 checks passed
@colin-foster-in-advantage
Copy link
Contributor Author

Thanks. Looks like it worked!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants