-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solax inverter model selector in config_flow to bypass discovery #115129
Add solax inverter model selector in config_flow to bypass discovery #115129
Conversation
…home-assistant#66617). Adapt code to upstream solax-3.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @squishykid, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You beat me to it 😄
PS. you might want to remove the spaces before/after the x
s in the Checklist
section. Github isn't handling that correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant to click 'Request changes', not 'Approve'...
better handling of missing inverter config entry multiple=false in config_flow for inverter selector
made a few more changes following your feedback, WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Mind opening an issue on the solax repo about ALL_COMPLETED not working for you?
@brew-your-own the PR has merge conflicts, can you fix them or rebase the PR and click the "Ready for review" button when done please? |
Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale. Feel free to re-open this PR when you are ready to pick up work on it again 👍 ../Frenck |
Proposed change
Add a selector for the type of Inverter in the solax integration config flow.
This will bypass the inverter discovery code which tends to crash some of the dongles out there.
This was made possible by release 3.1.0 in the upstream solax library which introduced a revamped
discovery code and the ability to only discovery a subset of all inverters, see
squishykid/solax#145
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: