Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump solax to 3.2.3 #134876

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Bump solax to 3.2.3 #134876

merged 3 commits into from
Jan 6, 2025

Conversation

squishykid
Copy link
Contributor

@squishykid squishykid commented Jan 6, 2025

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@squishykid
Copy link
Contributor Author

squishykid commented Jan 6, 2025

Actually I will close this and raise a separate PR, i want to include another change
Cancel that, i will just update this one

@squishykid squishykid closed this Jan 6, 2025
@squishykid squishykid reopened this Jan 6, 2025
@squishykid squishykid changed the title Bump solax to 3.2.2 Bump solax to 3.2.3 Jan 6, 2025
@joostlek joostlek merged commit e4eb414 into home-assistant:dev Jan 6, 2025
65 checks passed
@joostlek
Copy link
Member

joostlek commented Jan 6, 2025

It would also be nice if we can finally start moving the entity definitions from the library to the integration

@joostlek joostlek added this to the 2025.1.1 milestone Jan 6, 2025
@squishykid
Copy link
Contributor Author

@joostlek do you have an example or docs I can see to show what you mean by moving the entities? Let me see what I can do.

@joostlek
Copy link
Member

joostlek commented Jan 6, 2025

You currently have all the data points and the name of the data points in the library from which you create entities. Ideally we create sensor entity descriptions in home assistant which describes what entities to expose. This allows us to translate the entity names for example

frenck pushed a commit that referenced this pull request Jan 6, 2025
@frenck frenck mentioned this pull request Jan 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants