-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor fan in vesync #135744
base: dev
Are you sure you want to change the base?
Refactor fan in vesync #135744
Conversation
Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This code also includes the changes required for #133545. Figured those changes were minor within the refactor. I have added the mapping / speed values so this PR could move before fixing that in the core library etc if we decide to. |
None of the check list items seem to be checked. Has this been tested in any real device? |
Left them unchecked since I need that pyvesync item merged before this can proceed. I owe a 131s, while the code runs it doesn't present modes as expected based on the bug in the library. Leaving as draft for now until that bug is fixed so I can retest it. Otherwise code works on my 131s without errors but mode feature disables. |
The upstream PR I needed has been merged. Once that is a released version I will create a PR to bump the library here. That should resolve the tests, as well as allow me to physically test and then be ready for merge. |
Proposed change
Refactor veysnc to follow the changes in other platforms. Remove much of the dependency on lookup tables.
Two items left here before fan.py doesn't need lookup:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: