Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fan in vesync #135744

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Refactor fan in vesync #135744

wants to merge 14 commits into from

Conversation

cdnninja
Copy link
Contributor

@cdnninja cdnninja commented Jan 16, 2025

Proposed change

Refactor veysnc to follow the changes in other platforms. Remove much of the dependency on lookup tables.

Two items left here before fan.py doesn't need lookup:

  1. (done) A bug fix here for the 131 device that will allow tests to pass: fix: 131s add modes webdjoe/pyvesync#267
  2. device.speeds doesn't exist, to get the speed we have to reach into a private _ method. I am interested in thoughts if I just go for that. Or submit a pull request to add device.speeds to pyvesync.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdnninja
Copy link
Contributor Author

This code also includes the changes required for #133545. Figured those changes were minor within the refactor. I have added the mapping / speed values so this PR could move before fixing that in the core library etc if we decide to.

@iprak
Copy link
Contributor

iprak commented Jan 16, 2025

None of the check list items seem to be checked. Has this been tested in any real device?

@cdnninja
Copy link
Contributor Author

Left them unchecked since I need that pyvesync item merged before this can proceed. I owe a 131s, while the code runs it doesn't present modes as expected based on the bug in the library. Leaving as draft for now until that bug is fixed so I can retest it.

Otherwise code works on my 131s without errors but mode feature disables.

@cdnninja
Copy link
Contributor Author

The upstream PR I needed has been merged. Once that is a released version I will create a PR to bump the library here. That should resolve the tests, as well as allow me to physically test and then be ready for merge.

@cdnninja cdnninja marked this pull request as ready for review February 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants