Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels: Don't build azure-servicebus on cp311 #91862

Merged
merged 3 commits into from
Apr 22, 2023
Merged

Wheels: Don't build azure-servicebus on cp311 #91862

merged 3 commits into from
Apr 22, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 22, 2023

Proposed change

This PR disables building wheels for the Azure Service Bus integration. It depends on the azure-servicebus Python package, which has uamqp as a subdepedency.

uamqp is the problem maker in this case, as it specifically requires OpenSSL 1.1 to build, while we build our Python 3.11 wheels on Alpine Linux 3.17, which ships with OpenSSL 3.0.x.

Although Alpine provides a compatibility package (openssl1.1-compat-dev) that technically should be sufficient to build wheels, it does conflict with our existing OpenSSL development headers.

At this point, there is no direct path forward. This resulting in this integration becoming unusable on our container-based installation types once we switch to Python 3.11.

Everything in this PR, including the above, does not affect our current releases.

Upstream issue: Azure/azure-uamqp-python#276

CC @hfurubotten (codeowner of the azure_service_bus integration)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Apr 22, 2023
@frenck frenck merged commit 0f80d06 into dev Apr 22, 2023
@frenck frenck deleted the frenck-2023-0717 branch April 22, 2023 17:29
joanwa pushed a commit to joanwa/home-assistant that referenced this pull request Apr 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants