-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Freebox router Raid warning to one occurence #98740
Reduce Freebox router Raid warning to one occurence #98740
Conversation
Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
What bothers me is that the component supposed to abstract the router differences should be the library, not the HA component: https://github.com/hacf-fr/freebox-api I opened a discussion there: hacf-fr/freebox-api#567 |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
b58fd40
to
a2f9800
Compare
a2f9800
to
b83cc99
Compare
b83cc99
to
32bcae8
Compare
I ended up following the style introduced by the method |
Please don't amend or squash commits after review has started to make it easier for readers to track changes. Thanks! |
32bcae8
to
9a4671d
Compare
9a4671d
to
71253e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit late to approve, but still: approved 🎉
Thanks @fthiery !
Proposed change
#95242 added RAID info to disks attached to Freebox routers, but fail the integration to start for people without disks or RAID (with a generic error
(APIResponse: {"msg": "Erreur interne", "success": false, "error_code": "internal_error"}
), its fix #97696 added try-catch with a warn, but in the update function (causing thousands of warnings to appear in the logs). It should be at init, then use a boolean or other to not warn more.This PR sets a boolean in case of failure so that subsequent calls are not done anymore.
Models that seemingly do not support raid enumeration are
However, i believe that this kind of model-specific handling should be done at the underlying level, and opened a corresponding discussion here: hacf-fr/freebox-api#567
Type of change
Additional information
Checklist
black --fast homeassistant tests
)