-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python version #2537
base: master
Are you sure you want to change the base?
Update python version #2537
Conversation
And include an hint to use pyenv
📝 WalkthroughWalkthroughThe pull request updates the development environment documentation to specify Python 3.13 as the required version for setting up the development environment. This change reflects an update in the recommended Python version, acknowledging that Python 3.13 may not be widely available in standard distributions and suggesting the use of version management tools like pyenv for installation. Changes
Note: There are no sequence diagrams to generate for this documentation update, as it's a simple version requirement modification. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/development_environment.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/development_environment.mdx (6)
Pattern */**(html|markdown|md)
: - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
Pattern */**(html|markdown|md)
: - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
Pattern */**(html|markdown|md)
: - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Pattern */**(html|markdown|md)
: - Use sentence-style capitalization also in headings.
Pattern */**(html|markdown|md)
: do not comment on HTML used for icons
Pattern */**(html|markdown|md)
: Avoid flagging inline HTML for embedding videos in future reviews for this repository.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
It is also possible to set up a more traditional development environment. See the section below for your operating system. Make sure your Python version is 3.12. | ||
It is also possible to set up a more traditional development environment. See the section below for your operating system. | ||
|
||
You currently need to use Python version 3.13 to create the virtual environment. This is not yet common in distributions, so you may want to use something like pyenv. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just keep changing the version number. The addition on the distribution is becoming more odd over time, as some might have it, others won't.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Correct Python 3.12 -> 3.13. This was bumped over Christmas, and you can't currently pip install homeassistant==2025.2.0.dev0 on 3.12.
Type of change
Additional information
It might be worth pointing out that the devcontainers work fine without vscode. Happy to include a section for that if useful?
Summary by CodeRabbit