-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Remove useless get sentences #2602
Conversation
Counting previous sentences for language: fr: 1367291763 New count: -1089632456 |
area: "cuisine" | ||
state: "off" | ||
response: "Non, pas téléphone" | ||
response: "Non, fermée" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response: "Non, fermée" | |
response: "Non" |
What about removing the state from the response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Co-authored-by: Paul Bottein <[email protected]>
@synesthesiam I'd like a small review on that one as it was a pain to do it. Thx a lot! |
* First removal of Sensor and Binary sensor useless fluff * Doors, Windows * Garage Door * Occupancy * Fix colission wiht locks * Responses * Update sentences/fr/_common.yaml Co-authored-by: Paul Bottein <[email protected]> * Simplify more the one_yesno response --------- Co-authored-by: Paul Bottein <[email protected]>
Complete Overall of the Get Sentences.
Generic sentences
The generic sentences to get anything are kept.
They are on homeassistant_HassGetState.yaml
Device Class x Sensor sentences
I completely removed all sentences targeting a specific device class on the
sensor
domain. Currently located on sensor_HassGetState.yaml.Reasoning
Each sentence on this file expects the user to name their entity the same way as their device.
What's the battery of the tesla?
is a perfectly valid sentence.However, out of the box, the working sentence would be more
What's the battery of the Tesla battery?
It's a lot of sentences, targeting lots of obscure device classes such as Moisture, Irradiation, Precipitation intensity, Volatile organic compounds ...
Most of these things will never be queried by voice.
However, being in the repo, it slows down a lot the intent matching and sometimes leads to incorrect matching If the sentences are not specific enough.
The generic sentences should be enough for now.
If a user wants to query their tesla battery by voice, they simply have to expose it, and say
What's the tesla battery
.The generic sentence will match.
I think these sentences will have their place in the repo once we are able to target actual
devices
instead of entities.Device Class X Binary Sensor sentences
I removed most of the device class and kept what makes sense to target by voice
I extended the scope of these sentences to cover more use cases that are valid.
(Basically focusing on depth instead of breadth)
Here they are
For the occupancy, we did not specify the following sentences
Yes/no
on a specific element (Is the Aqara FP2 presence sensor detected.)which
question (Which presence sensor is detected)All
question targeting theON
state (are all the presence sensor in the house detected)Any
question targeting theOFF
state (is there any presence sensor in the living room that is NOT detecting presence)any
sentence for the whole house (Is there someone home) because we were afraid it would collide with thezone
orperson
domain.None of them are making a ton of sense compared to what is specified