Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to set
:hackney_opts
in the configuration which is passed onto hackney. I didn't see any tests of configuration, but this works in local for me. This resolves the first part of #467.To force IPv6 with hackney I can now set the config with:
But dual stack could still be an issue since it'll always default to IPv4 in hackney.
As discussed in #467 it would be better if it was possible to pass in a HTTP client adapter. That would remove things that arguably should be outside the scope of this library, like the HTTP proxy tunnel or the connection pool. The default startup could still include hackney with some sane defaults (e.g. starting connection pool).