Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return the actual key from getSampleRateKey #282

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Return the actual key from getSampleRateKey #282

merged 1 commit into from
Nov 13, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • We had a function that was supposed to return the sampleRate key being used, but instead it always returned sampleRate, which broke things that didn't use that exact case.

Short description of the changes

  • Return the actual key in use
  • Adjust the test to use it

@kentquirk kentquirk requested a review from a team as a code owner November 13, 2024 19:20
@kentquirk kentquirk merged commit d762868 into main Nov 13, 2024
6 checks passed
@kentquirk kentquirk deleted the kent.fix_sampleRate_key branch November 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainofTerra RainofTerra RainofTerra approved these changes

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kentquirk @RainofTerra @VinozzZ