wip #1492
Draft
wip #1492
+240
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
force-pushed
the
yingrong/refinery_opamp_bytes_received
branch
from
62b19f4 to
b7bdf3f
Compare
kentquirk
reviewed
Feb 22, 2025
| return 0, fmt.Errorf("value %f is too large to convert to int64", value) | ||
| } | ||
| if value < math.MinInt64 { | ||
| return 0, fmt.Errorf("value %f is too small to convert to int64", value) |
There was a problem hiding this comment.
"too small" is probably the wrong phrase here -- MinInt64 is a very large negative number.
I'm also wondering why you bothered to introduce this function at all. It's not actually wrong, but if you had just used int64(value) it would only error if a single report is more than about 9000 terabytes. Then addOTLPSum() wouldn't have to return errors either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes