Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Req.txt and resolved conflicts #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PranshuLakhotia
Copy link

Implemented the changes with respect to PR #14.
Added req.txt
Reverted back to the old port

Pls review it @gtheodoridis.
Thank You.

@PranshuLakhotia
Copy link
Author

@gtheodoridis solved the issue #22 with the latest commit pls review.
Changes made:

  1. Modified the DICOMParser class to use getattr() with default values.
  2. Updated get_patient_info(), get_study_info(), and get_series_info() methods to handle missing attributes gracefully.
  3. Enhanced test cases to verify parser behavior with potentially missing attributes.

Files changed:

  • dicom_server/dicom_parser.py
  • dicom_server/test_dicom_parser.py

Testing:

  • All existing tests pass
  • New tests added to verify handling of missing attributes

Here is the ss of the same

image

@PranshuLakhotia
Copy link
Author

@gtheodoridis awaiting your response.
Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant