Skip to content

Commit

Permalink
chore: fix check notes
Browse files Browse the repository at this point in the history
  • Loading branch information
hongyuanjia committed Mar 19, 2024
1 parent 773e0b2 commit ecc1695
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 5 deletions.
5 changes: 3 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Version: 0.0.0.9000
Authors@R:
person("Hongyuan", "Jia", , "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-0075-8183"))
Description: A toolkit to convert 'DeST' models to 'EnergyPlus' models
Description: A toolkit to convert 'DeST' models to 'EnergyPlus' models.
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
Expand All @@ -15,7 +15,8 @@ Imports:
data.table,
DBI,
eplusr,
odbc
odbc,
RSQLite
Suggests:
archive,
httr2,
Expand Down
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export(download_dest_model)
export(read_dest)
export(to_eplus)
importFrom(DBI,dbConnect)
importFrom(RSQLite,SQLite)
importFrom(data.table,fread)
importFrom(eplusr,empty_idf)
importFrom(odbc,odbc)
1 change: 1 addition & 0 deletions R/destup-package.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
#' @importFrom DBI dbConnect
#' @importFrom eplusr empty_idf
#' @importFrom odbc odbc
#' @importFrom RSQLite SQLite
## usethis namespace: end
NULL
8 changes: 7 additions & 1 deletion R/utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@ is_character <- function(x) {
all(!is.na(x)) && is.character(x)
}

utils::globalVariables(c(".SD", "NAME", "MATERIAL_NAME"))
utils::globalVariables(c(
".SD", "J", ":=", ".BY", # data.table

"BOUNDARY_OBJECT", "BOUNDARY", "CONSTRUCTION", "KIND_ENCLOSURE", "LAYER_NO",
"MATERIAL_NAME", "MATERIAL_ID", "NAME", "POINT_NO", "POINT_X", "POINT_Y",
"POINT_Z", "ROOM", "STOREY_MULTIPLIER", "TYPE_SURFACE", "TYPE"
))
2 changes: 1 addition & 1 deletion man/destup-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat/test-conv.R
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,5 @@ test_that("to_eplus() works", {
expect_s3_class(attr(surface, "table"), "data.table")

# can convert a DeST model to an EnergyPlus model
expect_s3_class(expect_message(idf <- to_eplus(dest)), "Idf")
expect_message(expect_s3_class(idf <- to_eplus(dest), "Idf"))
})

0 comments on commit ecc1695

Please sign in to comment.