Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry): added generic types #844

Closed
wants to merge 3 commits into from

Conversation

MathurAditya724
Copy link
Contributor

  • Added generic types for middleware handler and context

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 8f47c01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/sentry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @MathurAditya724

Thank you for the PR. I know the middleware handler can accept generics, but I would like to know your actual problem without generics. Other almost built-in middleware are not added generics types.

@MathurAditya724
Copy link
Contributor Author

Hey @yusukebe, I was encountering a persistent type error with this, even after multiple TS server restarts. Strangely, it’s no longer showing any errors today—I’m not sure what changed. Sometimes, VS Code can be a bit flaky, I guess. I’ll go ahead and close this PR now. Thanks for pointing it out!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants