Spring Security 작업 Exception 제외하고 완료 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donsonioc2010
requested changes
Oct 9, 2023
Comment on lines
88
to
90
| } else { | ||
| log.info("Username is null or context is not null !!"); | ||
| log.error("Username is null or context is not null !!"); | ||
| } |
| } | ||
| filterChain.doFilter(request, response); | ||
| } | ||
|
|
||
| // Filter에서 제외할 URL 설정 | ||
| @Override | ||
| protected boolean shouldNotFilter(HttpServletRequest request) throws ServletException { | ||
| return EXCLUDE_URL.stream().anyMatch(exclude -> exclude.equalsIgnoreCase(request.getServletPath())); | ||
| jwtProperties.getExcludePath().forEach(path -> log.error("path: {}\n", path)); |
There was a problem hiding this comment.
error레벨 말고 debug또는 info레벨로 수정
Comment on lines
59
to
61
| claimMap.put("email", email); | ||
| claimMap.put("password", password); | ||
| claimMap.put("role", role); |
There was a problem hiding this comment.
상수변수로 변경해주세요
이렇게 쓸거면 public static final 변수로 뽑고 다른 곳에서도 사용가능하게 Constants Class로 별도 지정하는게 어떨까 싶네요.
Comment on lines
10
to
11
| private String email; | ||
| private String password; |
There was a problem hiding this comment.
Suggested change
| private String email; | |
| private String password; | |
| @NotEmpty(message = "이메일 입력은 필수 입니다.") | |
| @Pattern(regexp = "^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+.[A-Za-z]{2,6}$", message = "이메일 형식에 맞지 않습니다.") | |
| private String email | |
| @NotEmpty(message = "패스워드 입력은 필수 입니다.") | |
| @Size(min = 3, max = 15) | |
| @Pattern(등등 추가) | |
| private String password; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Security 작업 Exception 제외하고 완료
TODO