[FEATURE] reply 기능 구현 완료 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
26
to
42
| private final ReplyService replyService; | ||
|
|
||
| @PostMapping | ||
| public void createReply(@RequestBody ReplyRequestDto requestDto) { | ||
| replyService.createReply(requestDto); | ||
| } | ||
|
|
||
| @GetMapping("/{articleId}") | ||
| public List<ReplyRequestDto> getReplyList(@PathVariable Long articleId, HttpServletRequest request) { | ||
| return replyService.getReplyList(articleId, LanguageType.findTypeByRequest(request)); | ||
| } | ||
|
|
||
| @DeleteMapping("/{replyId}") | ||
| public ResponseEntity<String> deleteReply(@PathVariable Long replyId) { | ||
| replyService.deleteReply(replyId); | ||
| return ResponseEntity.ok("삭제처리가 완료되었습니다."); | ||
| } |
There was a problem hiding this comment.
수정은 없는게 의도가 된 부분일까요?
Controller Mapping은 잘했습니다. 👍
많이 좋아졌네요.
There was a problem hiding this comment.
수정은 일부러 안넣었습니다. 감사합니다 !
| } | ||
|
|
||
| @GetMapping("/{articleId}") | ||
| public List<ReplyRequestDto> getReplyList(@PathVariable Long articleId, HttpServletRequest request) { |
There was a problem hiding this comment.
ReplyRequestDto가 클래스 명칭인데 Response를 해당 DTO로 하고있네요.
Naming은 좀 더 어울리게 수정이 필요할것 같네요.
|
|
||
| @NotNull | ||
| @Enumerated(EnumType.STRING) | ||
| private ReplyStatus isDeleted; |
There was a problem hiding this comment.
컬럼명칭이 replyStatus가 더 어울릴 것 같은 느낌이 드네요
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
|
|
||
| @OneToMany(mappedBy = "reply") |
Comment on lines
73
to
81
| @Builder | ||
| public Reply(Long id, LanguageType orgReplyLanguage, ReplyStatus isDeleted, | ||
| User createdUser, User updatedUser) { | ||
| this.id = id; | ||
| this.orgReplyLanguage = orgReplyLanguage; | ||
| this.isDeleted = isDeleted; | ||
| this.createdUser = createdUser; | ||
| this.updatedUser = updatedUser; | ||
| } |
There was a problem hiding this comment.
위에 @Builder가 명시되어있는데, 또 명시한 이유가 있을까요?
둘중 하나는 날려버리는게 좋지 않을까 하네요.
Comment on lines
+35
to
+36
| // .title(translateService.naverPapagoTextTranslate(requestDto.getOrgArticleLanguage(), languageType.getLanguageCode(), requestDto.getTitle())) | ||
| // .content(translateService.naverPapagoHtmlTranslate(requestDto.getOrgArticleLanguage(), languageType.getLanguageCode(), requestDto.getContent())) |
There was a problem hiding this comment.
이부분은 댓글 로직과 관련이 없어서 일단 막아놨습니다.
지금 pr이 merge되면 Article쪽 service 메서드 합치면서 수정하겠습니다.
Comment on lines
+69
to
+70
| getTranslatePapagoTextArticleContent(requestDto.getOrgArticleLanguage().getLanguageCode(), languageType.getLanguageCode(), requestDto.getTitle()), | ||
| getTranslatePapagoHTMLArticleContent(requestDto.getOrgArticleLanguage().getLanguageCode(), languageType.getLanguageCode(), requestDto.getContent())); |
There was a problem hiding this comment.
다른 pr로 게시글 쪽 번역 부분 다시 수정하겠습니다!
| @Transactional(readOnly = true) | ||
| public List<ReplyRequestDto> getReplyList(Long articleId, LanguageType language) { | ||
| Article article = articleRepository.findById(articleId).orElseThrow(() -> ArticleContentNotFoundException.EXCEPTION); | ||
| List<Reply> replyList = replyRepository.findAllByArticleAndDeleted(article, false); |
| public interface ReplyRepository extends JpaRepository<Reply, Long> { | ||
| List<Reply> findAllByArticleAndDeleted(Article article, boolean isDeleted); |
… into feat/28-reply branch merge 충돌 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
댓글 등록 / 조회 / 삭제 기능