Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all package managers and shrink package size #45

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

marvinroger
Copy link
Contributor

@marvinroger marvinroger commented Apr 9, 2023

This is a follow-up of hookdeck/go-npm#1, closes #44

This PR does two things:

  1. It adds the bin field required for cross packages managers compatibility (and needed after the go-npm-next update)
  2. It adds an empty files property to avoid shipping all the repo files to npm (right now, the package is 3.15 MB - this should drastically reduce the package size)

Checklist before being able to merge this:

  • I'd like to test with a real scenario by publishing a dummy package to npm, to check that everything works as it should
  • Add support for all packages manager and shrink package size go-npm#1 should be merged and deployed to npm
  • The lockfile of this PR should be updated after go-npm-next is updated on npm
  • An hookdeck-cli 0.6.6 release should be done, in order to bump the package.json and to publish the update to npm

@alexbouchardd
Copy link
Contributor

alexbouchardd commented Apr 11, 2023

Hey @marvinroger, thanks for opening those PRs and sorry for the late reply. Seemingly my notifications aren't working for this repo.

I've merged and published [email protected] see: hookdeck/go-npm#1

@alexbouchardd
Copy link
Contributor

Updated the lockfile

@alexbouchardd
Copy link
Contributor

Merging & creating a new 0.6.6 release. Merci beaucoup!

@alexbouchardd alexbouchardd merged commit 5bdca6b into hookdeck:master Apr 11, 2023
@alexbouchardd
Copy link
Contributor

FYI @marvinroger I needed to add back the postinstall script in 9f8e596 otherwise NPM was throwing

npm ERR! code 127
npm ERR! path /Users/alexbouchard/.nvm/versions/node/v16.13.1/lib/node_modules/hookdeck-cli
npm ERR! command failed
npm ERR! command sh -c go-npm install

This makes since on preinstall go-npm isn't installed yet.

v0.6.7 is now available with your changes!

@marvinroger
Copy link
Contributor Author

It's only been 3 days, it's totally fine 😉
Thanks for your reactivity in releasing the fixes, I can confirm it works great now.

Avec plaisir !

@marvinroger marvinroger deleted the fix/yarn-support branch April 12, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Yarn v2/v3/Berry
2 participants