Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate load testing #642

Merged
merged 2 commits into from
May 2, 2024
Merged

Automate load testing #642

merged 2 commits into from
May 2, 2024

Conversation

ausias-armesto
Copy link
Contributor

Update the load testing workflow to the latest infrastructure changes.

Copy link

changeset-bot bot commented May 2, 2024

⚠️ No Changeset found

Latest commit: 734fb99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ausias-armesto ausias-armesto requested a review from esterlus May 2, 2024 11:08
@ausias-armesto ausias-armesto self-assigned this May 2, 2024
Copy link
Member

@esterlus esterlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update node version.

I would rather not add default values to the env execution parameters (WALLET_TYPE and TEST_TYPE) but if you think we need it, I am ok with it.

.github/workflows/load-tests.yaml Outdated Show resolved Hide resolved
@ausias-armesto
Copy link
Contributor Author

ausias-armesto commented May 2, 2024

Please update node version.

I would rather not add default values to the env execution parameters (WALLET_TYPE and TEST_TYPE) but if you think we need it, I am ok with it.

We definitely need them grafana/k6-operator#376 (comment)

@ausias-armesto ausias-armesto requested a review from esterlus May 2, 2024 11:40
Copy link
Member

@esterlus esterlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, understood

@ausias-armesto ausias-armesto merged commit e07901a into main May 2, 2024
@ausias-armesto ausias-armesto deleted the ausias/automate-load-test branch May 2, 2024 11:45
@ausias-armesto ausias-armesto changed the title Automate load testting Automate load testing May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants