Scale nodes #45
Open
Scale nodes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2018 23:13
(i.e deploy_cns: False) on v3.10
1. hosts.j2 to define variables related to logging, metrics, grafana
when deploy_cns is False
2. If sp_app_id is defined in vars.yml, sp_app variable will not be populated
when executing the task azure_infra/tasks/cloudprovider.yml. Hence
adding the sp_app_id check before checking for sp_app in hosts.j2
3. Define sections for glusterfs, glusterfs_registry even when
deploy_cns is False. This is because we check for
'inventory_hostname in groups.glusterfs' while registering the
nodes to RHSM in roles/ocp_pre/tasks/subscribe.yml
4. Fixing the typos in vars.yml.example
- define deploy_grafana which will be used in hosts.j2
- modified app_subnet_cidr: "192.168.0.128/25" to
app_subnet_cidr: "192.168.0.128/27"
5. renamed vars deploy_grafan to deploy_grafana
Signed-off-by: shwethahp <[email protected]>
Signed-off-by: shwethahp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.