Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static factory for existing files #57

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

Schrank
Copy link
Contributor

@Schrank Schrank commented May 24, 2024

Fixes #56

@horstoeko
Copy link
Owner

Hi @Schrank,

Thank you for your PR. As I am always picky, I would like you to rename the variable $pdfData in the method signature to something more catchy. You assume that it must be a file name (your method is called "fromPdfFile". So I would think that the variable would be better named $pdfFileName. Furthermore, it would only be logical if you also had a fromPdfString method. Would you be so kind as to implement this accordingly? Otherwise I can only say: Good idea!

Best regards...

and improve variable naming
@Schrank
Copy link
Contributor Author

Schrank commented May 24, 2024

Done. I would love to add tests, but don't have the motivation to setup the project locally.

Therefore: It is untested (sorry, should have mentioned that!)

@horstoeko
Copy link
Owner

Done. I would love to add tests, but don't have the motivation to setup the project locally.

I think this is no problem in this case

Therefore: It is untested (sorry, should have mentioned that!)

Noted... Merging...

Best regards

@horstoeko horstoeko closed this May 24, 2024
@horstoeko horstoeko reopened this May 24, 2024
@horstoeko horstoeko merged commit a42cdc6 into horstoeko:master May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add static factory ZugferdDocumentPdfBuilder::fromPdfFile()
2 participants