Skip to content

Commit

Permalink
Merge branch 'develop' of github.com:hotosm/Drone-TM into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
nrjadkry committed Nov 22, 2024
2 parents deb917e + eb7d058 commit 132777d
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 1 deletion.
39 changes: 39 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
## What type of PR is this? (check all applicable)

- [ ] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation
- [ ] 🧑‍💻 Refactor
- [ ] ✅ Test
- [ ] 🤖 Build or CI
- [ ] ❓ Other (please specify)

## Related Issue

Example: Fixes #123

## Describe this PR

A brief description of how this solves the issue.

## Screenshots

Please provide screenshots of the change.

## Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

## Review Guide

Notes for the reviewer. How to test this change?

## Checklist before requesting a review

- 📖 Read the HOT Code of Conduct: <https://docs.hotosm.org/code-of-conduct>
- 👷‍♀️ Create small PRs. In most cases, this will be possible.
- ✅ Provide tests for your changes.
- 📝 Use descriptive commit messages.
- 📗 Update any related documentation and include any relevant screenshots.

## [optional] What gif best describes this PR or how it makes you feel?
2 changes: 1 addition & 1 deletion src/backend/app/projects/image_processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ async def download_and_upload_assets_from_odm_to_s3(
:param current_state: Current state of the task (IMAGE_UPLOADED or IMAGE_PROCESSING_FAILED).
"""
log.info(f"Starting download for task {task_id}")

# Replace with actual ODM node details and URL
node = Node.from_url(node_odm_url)

Expand Down Expand Up @@ -319,6 +318,7 @@ async def download_and_upload_assets_from_odm_to_s3(
)

finally:
# Clean up the temporary directory
if os.path.exists(output_file_path):
try:
shutil.rmtree(output_file_path)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ const MapSection = ({ className }: { className?: string }) => {
},
onError: (err: any) => {
toast.error(err?.response?.data?.detail || err.message);
dispatch(setSelectedTakeOffPoint(null));
},
});

Expand Down

0 comments on commit 132777d

Please sign in to comment.