-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat capacitor geolocation #1016
Merged
spwoodcock
merged 4 commits into
hotosm:development
from
NSUWAL123:feat-capacitor-geolocation
Nov 29, 2023
Merged
Feat capacitor geolocation #1016
spwoodcock
merged 4 commits into
hotosm:development
from
NSUWAL123:feat-capacitor-geolocation
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegrated for device position & orientation
…cation with capacitor geolocation
varun2948
approved these changes
Nov 29, 2023
spwoodcock
approved these changes
Nov 29, 2023
Oops, missed the updated lock file. The frontend test failed but I merged 🫢 |
Can you include the lockfile in your other PR? |
@spwoodcock the |
It's not the package-lock.json we need. |
nischalstha9
pushed a commit
to naxa-developers/fmtm
that referenced
this pull request
Dec 8, 2023
* feat (projectDetails): geolocation - capacitor geolocation & motion integrated for device position & orientation * feat (vectorLayer): geolocationImage - rotate image when device orientation changes * fix (projectDetails): mapControlComponent - relplaced navigator geolocation with capacitor geolocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates
geolocation
&motion
fromcapacitor
. Also the current geolocation fetch from the navigator is replaced with capacitor. There are more enhancements to be done for device orientation.