-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-generated mbtile files for each task area in a project #1080
Conversation
I don't believe pmtiles will work for ODK Collect. |
No they won't. The idea is:
|
I have revised the output format for task-wise tiles to use MBTiles. Would it be okay to initiate this endpoint during the project generation process? The endpoint already generates tiles in the background. What do you think @spwoodcock? The idea is to trigger this endpoint at the end of project creation process, passing |
get_project_sync = async_to_sync(get_project) | ||
project = get_project_sync(db, project_id) | ||
|
||
from app.s3 import add_file_to_bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try not to import inline like this, it goes against the PEP8 style guide. Always import at the top of the file 👍
Code is good, but this is a larger PR than the initial code suggests and requires modifying the backend and frontend together. The code as it is will break the functionality of generating individual tile archives. I will push some changes to keep the existing functionality, while also running in the background on project creation as mentioned. |
145ab87
to
884eeb6
Compare
I took a quick look at this & made some edits. I split out into two endpoints:
Could I ask for some assistance with:
|
@spwoodcock @varun2948 @NSUWAL123 where are we with making changes in the frontend for this PR. |
050b051
to
daf9cfb
Compare
I'll look at fixing conflicts and working on a basic frontend implementation in the coming days 👍 |
Closing for now as this is too far out of sync. We can return to it in future and use this as inspiration. |
Fixes #890
/orgid/projectid/basemap.mbtiles
@spwoodcock has suggested to use pmtiles rather than mbtiles when generating the project wise mbtiles. I was wondering if these pmtiles generated works for odk collect? And if not, do we need project wise mbtiles too.