-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed outline and task info from project/id endpoint #1120
Conversation
3c9d03c
to
7ab7b7a
Compare
It's fine to remove the tasks from the response on the backend, but that's a tiny part of the task in issue #935. Most of the edits are on the frontend, where we need to load the project info first, then progressively load in task data as it's returned.
|
Oh okay. Then fetching data in chunks rather than all at once in frontend must be the desired behaviour? |
Possibly! It's probably not worth optimising for now. Only the basic version is necessarily, then we can improve later. |
Closing for now - we will come back to this and coordinate with the frontend. |
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
This changes removes the inherited
ProjectBase
schema model fromReadProject
where only required fields are defined which excludesoutline_geojson
andproject_tasks
.Response
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?