Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyxform fork for BytesIO XForm usage #1327

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Describe this PR

  • We need temp files currently to move the XForm around.
  • I made a patch to hotosm/pyxform with a PR in that repo.
  • Until the PR is merged, we can use the forked repo code.
  • Allows using BytesIO objects for XForm reading, conversion, and validation.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added this to the FMTM 2024.04 Release milestone Mar 5, 2024
@spwoodcock spwoodcock self-assigned this Mar 5, 2024
@github-actions github-actions bot added the backend Related to backend code label Mar 5, 2024
@spwoodcock spwoodcock merged commit b100443 into development Mar 5, 2024
5 of 6 checks passed
@spwoodcock spwoodcock deleted the refactor/pyxform-bytesio branch March 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code
Projects
Development

Successfully merging this pull request may close these issues.

1 participant