Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank space input validation #1362

Merged

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

A brief description of how this solves the issue.
This PR adds validation to different form validations to validate input field. Currently the input fields doesn't validate white spaces and doesn't show error. Now before comparing input value with empty string, the input value is first trimmed then compared with empty string.

Please provide screenshots of the change.
Validation white spaces also:
image

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@NSUWAL123 NSUWAL123 requested a review from varun2948 March 18, 2024 10:19
@github-actions github-actions bot added the frontend Related to frontend code label Mar 18, 2024
@NSUWAL123 NSUWAL123 requested a review from spwoodcock March 18, 2024 10:20
@spwoodcock spwoodcock merged commit 2dc0094 into hotosm:development Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project can be created only using spaces as project name
2 participants