-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat project details geolocation integration #1374
Feat project details geolocation integration #1374
Conversation
β¦t-details-geolocation-integration
@spwoodcock , @varun2948 . It seems that some of the browser doesn't support |
β¦t-details-geolocation-integration
We mostly used this in mobile and most of the android is based on chromium and chrome so i think it will not be that much of a problem. What's your say @spwoodcock ? |
Damn, didn't realise that! I thought the error on Firefox was because of my privacy settings / disabled geolocation. At the very least we shouldn't have an error if not available. It should be caught gracefully and displayed to the user that no geolocation is available. This will be perfect for the demo, but we probably also need to support Safari in the future too (I'll merge this and make an issue for another PR) |
@spwoodcock, fixed the page crash error on another PR |
What type of PR is this? (check all applicable)
Related Issue
Also solves #1343
Describe this PR
This PR covers the following things:
A brief description of how this solves the issue.
Screenshots
Alternative Approaches Considered
Did you attempt any other approaches that are not documented in code?
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?