Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock map feature if 'Map Feature In ODK' clicked #1516

Merged
merged 10 commits into from
May 24, 2024

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR contains the following works done:

  1. Entities status update to locked for mapping on Map feature in ODK button click.
  2. Update parent task to locked for mapping if child entity status update to locked for mapping.
  3. Map feature in ODK disable on certain conditions

Screenshots

  • Task locked by user itself
    image

  • Entity already locked for mapping
    image

  • If parent task status is not READY or LOCKED_FOR_MAPPING
    image

@NSUWAL123 NSUWAL123 marked this pull request as draft May 13, 2024 07:44
@github-actions github-actions bot added the frontend Related to frontend code label May 13, 2024
@spwoodcock spwoodcock changed the title Feat/map feature odk Lock map feature if 'Map Feature In ODK' clicked May 21, 2024
@NSUWAL123 NSUWAL123 marked this pull request as ready for review May 24, 2024 10:07
@NSUWAL123 NSUWAL123 requested review from varun2948 and spwoodcock May 24, 2024 10:07
@NSUWAL123
Copy link
Contributor Author

It is ready but before merging to staging this feature needs to be tested.

CC: @manjitapandey

@spwoodcock
Copy link
Member

Looks good πŸ‘ Can be tested on dev πŸ˜„

@spwoodcock spwoodcock merged commit dfb5e7b into hotosm:development May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants