Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload multiple geojson for janakpur #860

Merged
merged 11 commits into from
Sep 28, 2023
Merged

Upload multiple geojson for janakpur #860

merged 11 commits into from
Sep 28, 2023

Conversation

nrjadkry
Copy link
Member

No description provided.

@nrjadkry nrjadkry temporarily deployed to test September 28, 2023 12:36 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to test September 28, 2023 12:37 Inactive
@nrjadkry nrjadkry temporarily deployed to test September 28, 2023 13:19 — with GitHub Actions Inactive
@spwoodcock
Copy link
Member

For easier refactoring in the future, any client specific 'quick and dirty' edits would be best placed under a separate router.

IMO we should have janakpur_crud.py and janakpur_routes.py to handle this, as we will likely remove the specific endpoints in the future (and integrate a more generic way).

@spwoodcock
Copy link
Member

I'll merge this now as you probably need the changes for tomorrow 👍

@spwoodcock spwoodcock merged commit d804065 into development Sep 28, 2023
2 checks passed
@spwoodcock spwoodcock deleted the upload-multiple-geojson-for-janakpur branch September 28, 2023 18:06
@spwoodcock spwoodcock added priority:low Backlog of tasks that will be addressed in time backend Related to backend code labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrjadkry nrjadkry

Labels
backend Related to backend code priority:low Backlog of tasks that will be addressed in time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrjadkry @spwoodcock