-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from npm to pnpm, webpack to vite #884
Conversation
Please change the base branch from main --> development. In the future we may make this the default branch, but for now we have to manually change on each PR. Thanks! |
Ohh will do! 👍 |
Thanks! 😄 |
Looks like you branched from main at the start - sorry it's not very clear that we do all development and merging with the This is a good prompt that we should probably clarify the process a bit better in the docs. To fix this PR, you can either rebase: Or easier may be to make a new branch and cherry pick your commits there 👍 |
Also you probably noticed the CI triggering on each push, so it may be better to push in batches of that's ok |
No worries! Yeah I did a merge and tried to solve the conflicts, seems I messed up the backend folder though... Just trying to sort that at the moment :) |
Yep 👍 |
ughh :( |
There we go! 😄 |
for more information, see https://pre-commit.ci
(sorry have still been doing quite a few individual pushes, just was trying to sort my git tree) :) |
Should be ready for a review now @spwoodcock 🎉 - I also migrated the frontend testing from Jest -> Vitest - seemed Vite just didn't want to play ball with Jest, and thought may as well move to Vitest while I'm at it with the Vite migration. |
…from webpack -> vite
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR - great stuff - I will do a build and test tomorrow and merge in 👍
Perfect thanks! |
Thank you so much for your contribution @JoltCode ! It is really appreciated ! |
@all-contributors add @JoltCode for code |
I've put up a pull request to add @JoltCode! 🎉 |
Closes #882, closes #883